kunwp1 commented on code in PR #4268:
URL: https://github.com/apache/texera/pull/4268#discussion_r3105490454
##########
common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/udf/python/DualInputPortsPythonUDFOpDescV2.scala:
##########
@@ -34,11 +34,25 @@ class DualInputPortsPythonUDFOpDescV2 extends LogicalOp {
required = true,
defaultValue =
"# Choose from the following templates:\n" +
+ "# \n" +
+ "# UiParameter notes:\n" +
+ "# - A UiParameter is a user-editable value exposed in the property
panel and read from your Python code.\n" +
+ "# - Define UiParameter values in open() and then use them later in
your UDF methods.\n" +
+ "# - Active UiParameter calls appear in the property panel;
commented-out calls are ignored.\n" +
+ "# - Supported UiParameter types are STRING, INT/LONG, DOUBLE, BOOL,
and TIMESTAMP.\n" +
"# \n" +
"# from pytexera import *\n" +
"# \n" +
"# class ProcessTupleOperator(UDFOperatorV2):\n" +
- "# \n" +
+ "# @overrides\n" +
Review Comment:
I don't see the need of having three different copies as they are all using
the same APIs. Please move the comment on the top and remove duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
