kunwp1 commented on code in PR #4268:
URL: https://github.com/apache/texera/pull/4268#discussion_r3105585399
##########
amber/src/main/python/core/models/schema/attribute_type.py:
##########
@@ -78,6 +78,45 @@ class AttributeType(Enum):
}
+FROM_STRING_PARSER_MAPPING = {
+ AttributeType.STRING: str,
+ AttributeType.INT: lambda v: (
+ 0 if v is None or (isinstance(v, str) and v.strip() == "") else int(v)
+ ),
+ AttributeType.LONG: lambda v: (
+ 0 if v is None or (isinstance(v, str) and v.strip() == "") else int(v)
+ ),
+ AttributeType.DOUBLE: lambda v: (
+ 0.0 if v is None or (isinstance(v, str) and v.strip() == "") else
float(v)
+ ),
+ AttributeType.BOOL: lambda v: (
+ False
+ if v is None or (isinstance(v, str) and v.strip() == "")
+ else str(v).strip().lower() in ("true", "1", "yes")
Review Comment:
1. Could you create an issue to track this task?
2. The Text Input Scan already implements a similar feature where users can
specify a text input to be passed as a boolean to downstream operators. I
suggest following that implementation as a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
