aglinxinyuan commented on PR #4387: URL: https://github.com/apache/texera/pull/4387#issuecomment-4275103832
> > I’m relying on Copilot to review this in a few passes since it’s a large PR. I’ve already gone through the generated comments and agree with them. Please go ahead and address them. > > Thanks I addressed them. Can you check the LICENSE-binary and NOTICE-binary to make sure they include all our libraries and correct licenses. Thanks for adding the binary licensing scaffolding. There are some new comments, please check. I don’t think this is ready to merge yet because there are still release-blocking issues: Connector/J is still bundled as a Category X dependency, several Python packages pulled in by `python-lsp-server[all]` are GPL/LGPL but currently listed under Apache-2.0, and the new checker only verifies dependency presence, not correct license classification. As written, this PR improves the inventory, but it does not yet make the binary distribution license-compliant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
