aglinxinyuan opened a new pull request, #4415: URL: https://github.com/apache/texera/pull/4415
### What changes were proposed in this PR? This PR removes the `passToAllDownstream` flag from the `State` class and the corresponding branch in the default `processState` implementation, in both the Scala and Python sides of the engine. Background: when I originally introduced `passToAllDownstream`, I didn't think the design through carefully. In practice: - The flag is not set to `true` anywhere in the codebase. - The only code that reads it is the default `processState` itself, which means the flag has no observable effect today. - I don't plan to build any feature on top of this flag. The idea it was gesturing at (limiting how far a state propagates) will be reintroduced later as a proper "scope" concept with a different mechanism, not as a boolean carried on every `State` instance. After this PR, the default behavior of `processState` is: **pass the incoming state to all downstream operators**, unless an operator explicitly consumes it by overriding `processState` and returning `None` (Scala) / not returning a `State` (Python). This matches what the previous default was *trying* to express, minus the dead flag. ### Any related issues, documentation, discussions? Closes #4414 ### How was this PR tested? Tested with existing unit/integration tests — no test referenced `passToAllDownstream` / `pass_to_all_downstream`, and the default behavior after this change (`processState` returning the state as-is) is what the previous implementation already produced whenever the flag was effectively unused, i.e. in every current code path. No new tests were added because this is a pure removal of dead configuration with no new behavior to cover. ### Was this PR authored or co-authored using generative AI tooling? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
