Xiao-zhen-Liu commented on code in PR #4415:
URL: https://github.com/apache/texera/pull/4415#discussion_r3126274315
##########
amber/src/main/python/core/models/state.py:
##########
@@ -26,11 +26,8 @@
@dataclass
class State:
- def __init__(
- self, table: Optional[Table] = None, pass_to_all_downstream: bool =
False
Review Comment:
I am confused about the default value. Here you were defaulting
`pass_to_all_downstream` to `false`.
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/executor/OperatorExecutor.scala:
##########
@@ -29,13 +29,7 @@ trait OperatorExecutor {
def produceStateOnStart(port: Int): Option[State] = None
- def processState(state: State, port: Int): Option[State] = {
- if (state.isPassToAllDownstream) {
- Some(state)
- } else {
- None
- }
- }
+ def processState(state: State, port: Int): Option[State] = Some(state)
Review Comment:
I am confused about the default value. Here you are defaulting
`pass_to_all_downstream` to `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
