Copilot commented on code in PR #4430:
URL: https://github.com/apache/texera/pull/4430#discussion_r3114629700
##########
frontend/package.json:
##########
@@ -69,28 +62,23 @@
"monaco-editor-wrapper": "5.5.3",
"monaco-languageclient": "8.8.3",
"ng-zorro-antd": "17.4.1",
- "ng2-pdf-viewer": "9.1.5",
"ngx-color-picker": "12.0.1",
"ngx-file-drop": "16.0.0",
- "ngx-image-viewer": "1.0.13",
"ngx-json-viewer": "3.2.1",
"ngx-markdown": "17.2.1",
"papaparse": "5.4.1",
"path-browserify": "1.0.1",
"plotly.js-basic-dist-min": "2.29.0",
- "popper.js": "1.16.1",
"quill": "1.3.7",
"quill-cursors": "3.1.2",
"read-excel-file": "5.7.1",
"ring-buffer-ts": "1.0.3",
"rxjs": "7.8.1",
"tinyqueue": "2.0.3",
Review Comment:
`bin/frontend-proto-gen.sh` invokes
`frontend/node_modules/.bin/protoc-gen-ts_proto`, which is typically provided
by the `ts-proto` npm package. Since this PR removes `ts-proto` from
`dependencies`, the proto generation script will fail unless the plugin is
provided some other way. Consider keeping `ts-proto` as a `devDependency` (or
updating/removing the script if it's intentionally deprecated).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
