aglinxinyuan commented on PR #4430: URL: https://github.com/apache/texera/pull/4430#issuecomment-4285892968
> LGTM! > tested with: yarn install, yarn build, yarn test. > > One comment: Not a new issue introduced by this PR, but while we are cleaning up dependencies: the generated frontend proto files directly import @bufbuild/protobuf/wire. Today this package is only pulled transitively through ts-proto. Should we declare @bufbuild/protobuf explicitly in dependencies to match the direct import? > After thinking it through, we should avoid importing child dependencies more than once, especially when they’re already included as dependencies of other children. We should keep it minimal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
