aglinxinyuan commented on code in PR #4786: URL: https://github.com/apache/texera/pull/4786#discussion_r3177856763
########## common/workflow-core/src/test/scala/org/apache/texera/amber/core/storage/result/ResultSchemaSpec.scala: ########## @@ -0,0 +1,70 @@ +/* Review Comment: Fair concern. The motivation is that downstream readers deserialize this schema positionally and cast each slot to a concrete type, so a silent reorder/retype would break consumers without any local-file change being obvious in review (the OG Copilot thread above made the same point). Pinning the column list + types here lets a CI red flag catch the drift instead of waiting for a runtime cast failure. That said — happy to close this PR if you would prefer to skip it; just want to confirm before discarding the work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
