aglinxinyuan commented on code in PR #4786: URL: https://github.com/apache/texera/pull/4786#discussion_r3177882928
########## common/workflow-core/src/test/scala/org/apache/texera/amber/core/storage/result/ResultSchemaSpec.scala: ########## @@ -0,0 +1,70 @@ +/* Review Comment: Expanded the spec in 743cfb575a so it goes beyond redeclaring the schema. New runtimeStatisticsSchema coverage: stable name → index mapping for positional readers; unknown-name lookup throws and the error message names the missing column; `containsAttribute` returns false for unknown names; column names are unique; **`toRawSchema` → `fromRawSchema` round-trips names + types intact** (the cross-language serialization contract that Python and external consumers actually depend on); singleton-val identity. Parallel coverage added for `consoleMessagesSchema`. 12 tests total, all passing. Let me know if this changes your mind on closing — happy to either keep it or close if it still feels like ceremony. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
