Yicong-Huang opened a new pull request, #4878:
URL: https://github.com/apache/texera/pull/4878
### What changes were proposed in this PR?
After the runner switch (#4862, merged) and the standalone-component sweep
(#4873, queued), many specs that were excluded in #4862 now compile and pass
cleanly. Drop those entries from the exclusion lists in `tsconfig.spec.json`
and `angular.json`'s test target, plus a handful of mechanical Jasmine → Vitest
cleanups.
**Newly running** — 7 additional test files / 41 additional tests, including:
- Most service specs that transitively reach `auth.service`
(workflow-websocket, execute-workflow, udf-debug, user-config, operator-menu,
workflow-console, operator-reuse-cache-status, workflow-result-export,
workflow-result)
- workflow-result spec (the `done`-callback rewrite from #4862 is already in
place)
**Still excluded** — 48 component / service specs whose TestBed setups still
need to be ported from NgModule (`declarations: [...]`) to standalone-component
(`imports: [Standalone]`) form. Each will be its own follow-up batch under
#4861. Comments in `tsconfig.spec.json` document this.
### Mechanical cleanups along the way
- 2 `xit(` → `it.skip(`
- 4 `.toHaveBeenCalledOnceWith(` → `.toHaveBeenCalledExactlyOnceWith(`
- 3 `.mockReturnValue()` (no-arg, Jasmine permitted) →
`.mockReturnValue(undefined)` (Vitest requires the value)
- One partial-mock `as any` cast in code-debugger.spec
- `done`/`fail` stubs in download / preset specs whose tests are `it.skip`'d
pending async/await rewrites
### Local result
```
Test Files 21 passed | 3 skipped (24)
Tests 150 passed | 8 skipped | 2 todo (160)
```
Up from 14 passed / 109 tests on the #4862 baseline.
### Any related issues, documentation, discussions?
Builds on #4862 (merged) and #4873 (queued). Tracked under #4861.
### How was this PR tested?
`yarn run test:ci` exits 0 locally; CI exercises the same path.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Opus 4.7 (1M context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
