Copilot commented on code in PR #4878:
URL: https://github.com/apache/texera/pull/4878#discussion_r3178898756
##########
frontend/src/tsconfig.spec.json:
##########
@@ -11,33 +11,65 @@
},
"include": ["**/*.spec.ts", "**/*.d.ts", "vitest-globals.d.ts",
"jsdom-svg-polyfill.ts"],
"exclude": [
- // Component specs deferred to a follow-up PR. They pull entire
- // template trees through the spec compile; the new unit-test builder
- // does stricter component / module resolution than the legacy karma
- // path and surfaces hundreds of "is not a known property/element"
- // errors that boil down to standalone vs NgModule scope mismatch in
- // the existing TestBed setups. Re-enabling them is tracked in #4861.
- "**/*.component.spec.ts",
- // Service specs that transitively pull a NgModule-declared component
- // through their import chain (most reach `auth.service` →
- // `RegistrationRequestModalComponent`, whose template fails the same
- // type check). Deferred for the same follow-up.
- "**/coeditor-presence.service.spec.ts",
- "**/execute-workflow.service.spec.ts",
- "**/user.service.spec.ts",
- "**/workflow-websocket.service.spec.ts",
- "**/workflow-result-export.service.spec.ts",
- "**/udf-debug.service.spec.ts",
- "**/user-config.service.spec.ts",
- "**/operator-menu.service.spec.ts",
- "**/workflow-console.service.spec.ts",
- "**/operator-reuse-cache-status.service.spec.ts",
- "**/workflow-result.service.spec.ts",
- "**/download.service.spec.ts",
- "**/preset.service.spec.ts",
// jsdom polyfill is enough to instantiate jointjs but its zero-
// dimension fake matrices break the actual graph-geometry math
- // these tests assert on. Real fix is Vitest browser mode (#4861).
- "**/drag-drop.service.spec.ts"
+ // these tests assert on. Real fix is Vitest browser mode (#4866).
+ "**/drag-drop.service.spec.ts",
+
+ // Component / service specs whose TestBed setups still need to be
+ // adapted to the standalone-component world. The migration sweep
+ // (PR #4862 + PR #4873) made the runtime resolution succeed, but
+ // each TestBed configures `declarations: [...]` plus selective
+ // module imports — that combo no longer matches what the new
+ // builder expects from a standalone-component graph. Tracked as
+ // follow-ups under #4861.
+ "**/app/common/formly/preset-wrapper/preset-wrapper.component.spec.ts",
+ "**/app/common/service/user/config/user-config.service.spec.ts",
+ "**/app/common/service/user/user.service.spec.ts",
+
"**/app/dashboard/component/admin/execution/admin-execution.component.spec.ts",
Review Comment:
`tsconfig.spec.json` still excludes several service specs (e.g. user-config
and user service) that the PR description calls out as “newly running”. With
these patterns present, those specs won’t be type-checked or executed by the
unit-test builder. Either remove these entries if the specs now pass, or update
the PR description / tracking comments to reflect that they remain excluded.
##########
frontend/angular.json:
##########
@@ -94,21 +94,55 @@
"include": ["**/*.spec.ts"],
"setupFiles": ["src/jsdom-svg-polyfill.ts"],
"exclude": [
- "**/workflow-result.service.spec.ts",
- "**/download.service.spec.ts",
- "**/preset.service.spec.ts",
- "**/*.component.spec.ts",
- "**/coeditor-presence.service.spec.ts",
- "**/execute-workflow.service.spec.ts",
- "**/user.service.spec.ts",
- "**/workflow-websocket.service.spec.ts",
- "**/workflow-result-export.service.spec.ts",
- "**/udf-debug.service.spec.ts",
- "**/user-config.service.spec.ts",
- "**/operator-menu.service.spec.ts",
- "**/workflow-console.service.spec.ts",
- "**/operator-reuse-cache-status.service.spec.ts",
- "**/drag-drop.service.spec.ts"
+ "**/drag-drop.service.spec.ts",
+
"**/app/common/formly/preset-wrapper/preset-wrapper.component.spec.ts",
+ "**/app/common/service/user/config/user-config.service.spec.ts",
+ "**/app/common/service/user/user.service.spec.ts",
+
"**/app/dashboard/component/admin/execution/admin-execution.component.spec.ts",
+
"**/app/dashboard/component/admin/settings/admin-settings.component.spec.ts",
+
"**/app/dashboard/component/admin/user/admin-user.component.spec.ts",
+ "**/app/dashboard/component/dashboard.component.spec.ts",
+
"**/app/dashboard/component/user/filters-instructions/filters-instructions.component.spec.ts",
+
"**/app/dashboard/component/user/filters/filters.component.spec.ts",
+
"**/app/dashboard/component/user/list-item/list-item.component.spec.ts",
+
"**/app/dashboard/component/user/user-avatar/user-avatar.component.spec.ts",
+
"**/app/dashboard/component/user/user-computing-unit/user-computing-unit.component.spec.ts",
+
"**/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.spec.ts",
+
"**/app/dashboard/component/user/user-icon/user-icon.component.spec.ts",
+
"**/app/dashboard/component/user/user-project/user-project-list-item/user-project-list-item.component.spec.ts",
+
"**/app/dashboard/component/user/user-quota/user-quota.component.spec.ts",
+
"**/app/dashboard/component/user/user-workflow/user-workflow-list-item/user-workflow-list-item.component.spec.ts",
+
"**/app/dashboard/component/user/user-workflow/user-workflow.component.spec.ts",
+ "**/app/hub/component/about/about.component.spec.ts",
+
"**/app/hub/component/browse-section/browse-section.component.spec.ts",
+
"**/app/workspace/component/code-editor-dialog/breakpoint-condition-input/breakpoint-condition-input.component.spec.ts",
+
"**/app/workspace/component/code-editor-dialog/code-debugger.component.spec.ts",
+
"**/app/workspace/component/code-editor-dialog/code-editor.component.spec.ts",
+
"**/app/workspace/component/codearea-custom-template/codearea-custom-template.component.spec.ts",
+
"**/app/workspace/component/left-panel/left-panel.component.spec.ts",
+
"**/app/workspace/component/left-panel/operator-menu/operator-label/operator-label.component.spec.ts",
+
"**/app/workspace/component/left-panel/operator-menu/operator-menu.component.spec.ts",
+
"**/app/workspace/component/left-panel/settings/settings.component.spec.ts",
+
"**/app/workspace/component/left-panel/time-travel/time-travel.component.spec.ts",
+
"**/app/workspace/component/left-panel/versions-list/versions-list.component.spec.ts",
+
"**/app/workspace/component/menu/coeditor-user-icon/coeditor-user-icon.component.spec.ts",
+ "**/app/workspace/component/menu/menu.component.spec.ts",
+
"**/app/workspace/component/power-button/computing-unit-selection.component.spec.ts",
+
"**/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.spec.ts",
+
"**/app/workspace/component/property-editor/port-property-edit-frame/port-property-edit-frame.component.spec.ts",
+
"**/app/workspace/component/property-editor/property-editor.component.spec.ts",
+
"**/app/workspace/component/property-editor/typecasting-display/type-casting-display.component.spec.ts",
+
"**/app/workspace/component/result-panel/console-frame/console-frame.component.spec.ts",
+
"**/app/workspace/component/result-panel/error-frame/error-frame.component.spec.ts",
+
"**/app/workspace/component/result-panel/result-panel.component.spec.ts",
+
"**/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.spec.ts",
+
"**/app/workspace/component/workflow-editor/context-menu/context-menu/context-menu.component.spec.ts",
+
"**/app/workspace/component/workflow-editor/mini-map/mini-map.component.spec.ts",
+
"**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts",
+ "**/app/workspace/component/workspace.component.spec.ts",
+
"**/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts",
+ "**/app/workspace/service/preset/preset.service.spec.ts",
Review Comment:
This exclude entry keeps `execute-workflow.service.spec.ts` out of test
discovery. If the execute-workflow specs are meant to be part of the newly
running test set, this line should be removed (and kept consistent with
`tsconfig.spec.json`).
##########
frontend/angular.json:
##########
@@ -94,21 +94,55 @@
"include": ["**/*.spec.ts"],
"setupFiles": ["src/jsdom-svg-polyfill.ts"],
"exclude": [
- "**/workflow-result.service.spec.ts",
- "**/download.service.spec.ts",
- "**/preset.service.spec.ts",
- "**/*.component.spec.ts",
- "**/coeditor-presence.service.spec.ts",
- "**/execute-workflow.service.spec.ts",
- "**/user.service.spec.ts",
- "**/workflow-websocket.service.spec.ts",
- "**/workflow-result-export.service.spec.ts",
- "**/udf-debug.service.spec.ts",
- "**/user-config.service.spec.ts",
- "**/operator-menu.service.spec.ts",
- "**/workflow-console.service.spec.ts",
- "**/operator-reuse-cache-status.service.spec.ts",
- "**/drag-drop.service.spec.ts"
+ "**/drag-drop.service.spec.ts",
+
"**/app/common/formly/preset-wrapper/preset-wrapper.component.spec.ts",
+ "**/app/common/service/user/config/user-config.service.spec.ts",
+ "**/app/common/service/user/user.service.spec.ts",
+
"**/app/dashboard/component/admin/execution/admin-execution.component.spec.ts",
Review Comment:
`angular.json` still excludes user-config and user service specs explicitly.
If these specs are intended to be re-enabled (per PR description), they need to
be removed here as well; otherwise they won’t be discovered by the unit-test
builder even if they compile.
##########
frontend/src/tsconfig.spec.json:
##########
@@ -11,33 +11,65 @@
},
"include": ["**/*.spec.ts", "**/*.d.ts", "vitest-globals.d.ts",
"jsdom-svg-polyfill.ts"],
"exclude": [
- // Component specs deferred to a follow-up PR. They pull entire
- // template trees through the spec compile; the new unit-test builder
- // does stricter component / module resolution than the legacy karma
- // path and surfaces hundreds of "is not a known property/element"
- // errors that boil down to standalone vs NgModule scope mismatch in
- // the existing TestBed setups. Re-enabling them is tracked in #4861.
- "**/*.component.spec.ts",
- // Service specs that transitively pull a NgModule-declared component
- // through their import chain (most reach `auth.service` →
- // `RegistrationRequestModalComponent`, whose template fails the same
- // type check). Deferred for the same follow-up.
- "**/coeditor-presence.service.spec.ts",
- "**/execute-workflow.service.spec.ts",
- "**/user.service.spec.ts",
- "**/workflow-websocket.service.spec.ts",
- "**/workflow-result-export.service.spec.ts",
- "**/udf-debug.service.spec.ts",
- "**/user-config.service.spec.ts",
- "**/operator-menu.service.spec.ts",
- "**/workflow-console.service.spec.ts",
- "**/operator-reuse-cache-status.service.spec.ts",
- "**/workflow-result.service.spec.ts",
- "**/download.service.spec.ts",
- "**/preset.service.spec.ts",
// jsdom polyfill is enough to instantiate jointjs but its zero-
// dimension fake matrices break the actual graph-geometry math
- // these tests assert on. Real fix is Vitest browser mode (#4861).
- "**/drag-drop.service.spec.ts"
+ // these tests assert on. Real fix is Vitest browser mode (#4866).
+ "**/drag-drop.service.spec.ts",
+
+ // Component / service specs whose TestBed setups still need to be
+ // adapted to the standalone-component world. The migration sweep
+ // (PR #4862 + PR #4873) made the runtime resolution succeed, but
+ // each TestBed configures `declarations: [...]` plus selective
+ // module imports — that combo no longer matches what the new
+ // builder expects from a standalone-component graph. Tracked as
+ // follow-ups under #4861.
+ "**/app/common/formly/preset-wrapper/preset-wrapper.component.spec.ts",
+ "**/app/common/service/user/config/user-config.service.spec.ts",
+ "**/app/common/service/user/user.service.spec.ts",
+
"**/app/dashboard/component/admin/execution/admin-execution.component.spec.ts",
+
"**/app/dashboard/component/admin/settings/admin-settings.component.spec.ts",
+ "**/app/dashboard/component/admin/user/admin-user.component.spec.ts",
+ "**/app/dashboard/component/dashboard.component.spec.ts",
+
"**/app/dashboard/component/user/filters-instructions/filters-instructions.component.spec.ts",
+ "**/app/dashboard/component/user/filters/filters.component.spec.ts",
+ "**/app/dashboard/component/user/list-item/list-item.component.spec.ts",
+
"**/app/dashboard/component/user/user-avatar/user-avatar.component.spec.ts",
+
"**/app/dashboard/component/user/user-computing-unit/user-computing-unit.component.spec.ts",
+
"**/app/dashboard/component/user/user-dataset/user-dataset-explorer/user-dataset-file-renderer/user-dataset-file-renderer.component.spec.ts",
+ "**/app/dashboard/component/user/user-icon/user-icon.component.spec.ts",
+
"**/app/dashboard/component/user/user-project/user-project-list-item/user-project-list-item.component.spec.ts",
+ "**/app/dashboard/component/user/user-quota/user-quota.component.spec.ts",
+
"**/app/dashboard/component/user/user-workflow/user-workflow-list-item/user-workflow-list-item.component.spec.ts",
+
"**/app/dashboard/component/user/user-workflow/user-workflow.component.spec.ts",
+ "**/app/hub/component/about/about.component.spec.ts",
+ "**/app/hub/component/browse-section/browse-section.component.spec.ts",
+
"**/app/workspace/component/code-editor-dialog/breakpoint-condition-input/breakpoint-condition-input.component.spec.ts",
+
"**/app/workspace/component/code-editor-dialog/code-debugger.component.spec.ts",
+
"**/app/workspace/component/code-editor-dialog/code-editor.component.spec.ts",
+
"**/app/workspace/component/codearea-custom-template/codearea-custom-template.component.spec.ts",
+ "**/app/workspace/component/left-panel/left-panel.component.spec.ts",
+
"**/app/workspace/component/left-panel/operator-menu/operator-label/operator-label.component.spec.ts",
+
"**/app/workspace/component/left-panel/operator-menu/operator-menu.component.spec.ts",
+
"**/app/workspace/component/left-panel/settings/settings.component.spec.ts",
+
"**/app/workspace/component/left-panel/time-travel/time-travel.component.spec.ts",
+
"**/app/workspace/component/left-panel/versions-list/versions-list.component.spec.ts",
+
"**/app/workspace/component/menu/coeditor-user-icon/coeditor-user-icon.component.spec.ts",
+ "**/app/workspace/component/menu/menu.component.spec.ts",
+
"**/app/workspace/component/power-button/computing-unit-selection.component.spec.ts",
+
"**/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.spec.ts",
+
"**/app/workspace/component/property-editor/port-property-edit-frame/port-property-edit-frame.component.spec.ts",
+
"**/app/workspace/component/property-editor/property-editor.component.spec.ts",
+
"**/app/workspace/component/property-editor/typecasting-display/type-casting-display.component.spec.ts",
+
"**/app/workspace/component/result-panel/console-frame/console-frame.component.spec.ts",
+
"**/app/workspace/component/result-panel/error-frame/error-frame.component.spec.ts",
+ "**/app/workspace/component/result-panel/result-panel.component.spec.ts",
+
"**/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.spec.ts",
+
"**/app/workspace/component/workflow-editor/context-menu/context-menu/context-menu.component.spec.ts",
+
"**/app/workspace/component/workflow-editor/mini-map/mini-map.component.spec.ts",
+
"**/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts",
+ "**/app/workspace/component/workspace.component.spec.ts",
+
"**/app/workspace/service/execute-workflow/execute-workflow.service.spec.ts",
+ "**/app/workspace/service/preset/preset.service.spec.ts",
Review Comment:
This exclude entry prevents `execute-workflow.service.spec.ts` from running
under the new `@angular/build:unit-test` pipeline. The PR description lists
execute-workflow specs among those re-enabled; if that’s accurate, this line
should be removed from the exclude list (and from `angular.json`’s test exclude
list too).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
