Ma77Ball opened a new pull request, #4900:
URL: https://github.com/apache/texera/pull/4900
### What changes were proposed in this PR?
- StatisticsManager.get_statistics() computed idle_time as
total_execution_time - data_processing_time - control_processing_time with no
lower bound. Timing races between the accumulators could make this negative,
and the bad value would be propagated into WorkerStatistics.
- This PR floors idle_time at 0 using max(0, ...). The raw accumulators are
untouched, so debugging values are preserved — only the reported metric is
clamped.
### Any related issues, documentation, discussions?
closes: #4892
### How was this PR tested?
- test_statistics_manager.py:
test_idle_time_can_go_negative_when_processing_exceeds_total now asserts
idle_time == 0 for the overshoot case, and the xfail marker on
test_idle_time_should_never_be_negative was removed since it now passes.
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No (working on better solution with Claude)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
