aglinxinyuan opened a new issue, #5003: URL: https://github.com/apache/texera/issues/5003
## Summary Three areas under-tested in the current suite: | Target | Today | Why under-tested | |---|---|---| | `DownloadService` | **8 active `it.skip(...)` blocks** | All written against the Jasmine `done()` / `fail()` callback shape, which the vitest runner doesn't accept (#4861). | | `CodeEditorComponent` | a single "should create" smoke test | Most of the component's behaviour (operator-type → language detection, language-title formatting, coeditor cursor styles) goes untested. | | `AnnotationSuggestionComponent` | **no spec at all** | The two `@Output()` event emitters are unverified. | ## Plan * `download.service.spec.ts`: rewrite the eight `it.skip(...)` blocks with `firstValueFrom` / `await expect(...).rejects.toThrow(...)` against the same mocks, then add new cases for `downloadWorkflow`, `downloadOperatorsResult` (single-file path), `getWorkflowResultDownloadability`, default-filename fallback, and `isLogin=false` plumbing. * `code-editor.component.spec.ts`: add language-detection cases for the three V2 Python operator types + Java + unknown, assert `languageTitle` formatting, and exercise `getCoeditorCursorStyles` for valid clientId / colour shapes. * `annotation-suggestion.component.spec.ts`: new file. Cover input defaults, accept / decline event emission, and that the two emitters are independent. Both branches under active development (`main` and the `chore/monaco-lsp-v10` v10 upgrade) should run the new specs to completion. ## Verification plan - [ ] `yarn test` on `main` — all new specs pass - [ ] `yarn test` on `chore/monaco-lsp-v10` — same specs pass against the v10-rewritten editor / debugger code - [ ] No existing specs regress -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
