Ma77Ball opened a new pull request, #5007:
URL: https://github.com/apache/texera/pull/5007
### What changes were proposed in this PR?
Fixes a name-mangling bug in amber/src/main/python/core/models/operator.py.
Operator declared __internal_is_source (double underscore), which Python
rewrites per class. So SourceOperator.__internal_is_source = True was stored as
_SourceOperator__internal_is_source, while the property kept reading
_Operator__internal_is_source. Result: SourceOperator subclasses defaulted to
is_source = False, and only worked because ExecutorManager called the setter
afterward.
Fix: rename to _internal_is_source (single underscore, no mangling) in
Operator's class attribute, getter, setter, and SourceOperator's override. Also
removed a dead, mangled line in TableOperator.__init__.
### Any related issues, documentation, or discussions?
Closes: #4736
### How was this PR tested?
Updated amber/src/test/python/core/models/test_operator.py:
- Removed the bug-pinning test that asserted on the old mangled attribute
names.
- Removed the xfail marker from the contract test, which now passes:
SourceOperator() reports is_source is True.
All 29 tests in test_operator.py pass.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in Compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
