Yicong-Huang opened a new issue, #5018: URL: https://github.com/apache/texera/issues/5018
### Task Summary `amber/src/main/scala/org/apache/texera/workflow/WorkflowCompiler.scala` is exercised today only transitively, via `TestUtils.buildWorkflow` in 9 e2e/scheduler specs (DataProcessingSpec, PauseSpec, CheckpointSpec, ReconfigurationSpec, BatchSizePropagationSpec, WorkflowSchedulerSpec, CostBasedScheduleGeneratorSpec, DefaultCostEstimatorSpec, ExpansionGreedyScheduleGeneratorSpec). There is no dedicated `WorkflowCompilerSpec`. Behavioral regressions in `expandLogicalPlan` would surface as e2e failures, but indirectly — diagnosis goes through the engine. Direct unit tests covering the compiler's contracts (link topology, storage-port collection, error semantics) would localize failures and lock the contract before any refactor that consolidates this compiler with `workflow-compiling-service`'s copy. Add `WorkflowCompilerSpec` covering at minimum: - Linear plan compiles; physical plan has expected operators and links - Multi-branch graph yields the correct external `PhysicalLink` topology - Terminal logical op's non-internal output ports appear in `outputPortsNeedingStorage` - `opsToViewResult` non-terminal op output ports also appear - Strict mode (no `errorList`) throws on unresolvable scan source - Python codegen `#EXCEPTION DURING CODE GENERATION:` regex path throws in strict mode - Pin observed behavior on schema-propagation errors (whether they throw or silently produce `Left`) ### Task Type - [x] Testing / QA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
