Yicong-Huang opened a new pull request, #5017: URL: https://github.com/apache/texera/pull/5017
### What changes were proposed in this PR? Adds a second `ng run gui:test-browser` target backed by `@vitest/browser` + Playwright (chromium, headless), for specs that need real DOM/SVG geometry. The default jsdom `gui:test` path stays the fast loop; only the workflow-editor spec is routed to the browser target today. The spec itself needed three structural fixes orthogonal to the runner: 1. `WorkflowEditorComponent`, `ContextMenuComponent`, and `NzModalCommentBoxComponent` moved from `declarations:` to `imports:` (standalone since Angular 19). 2. `beforeEach(waitForAsync(...))` → `beforeEach(async () => ...)`, so the hook no longer needs an ambient ProxyZone (Vitest only wraps `it`, not `beforeEach`). 3. After (1) and (2), 16 of 22 tests pass under jsdom. The remaining 6 are pointer-event hit testing on the jointjs paper, which is exactly the case browser mode exists for — that's what this PR's `test-browser` target then runs (22/22 pass under chromium). In browser mode, Vite's default condition resolution picks the node entry for `uuid` (8.3.2) and `lib0/webcrypto` because neither package's `exports` map gates on a `browser` condition under `import`. The browser config aliases those two imports to their published browser bundles via absolute paths. ### Any related issues, documentation, discussions? Closes #4866. Removes one of the three entries from the `gui:test` exclude list cited in #4861. ### How was this PR tested? - `yarn ng test --watch=false` (jsdom): 67 files passed / 3 skipped, 376 tests passed / 9 skipped / 2 todo. - `yarn ng run gui:test-browser` (chromium): 1 file passed, 22 tests passed. - `yarn format:ci`: clean. ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Opus 4.7 (1M context) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
