Yicong-Huang commented on PR #5016:
URL: https://github.com/apache/texera/pull/5016#issuecomment-4437743484

   > Tested fully locally.
   > 
   > Built and ran all microservices (config / access-control / file / 
computing-unit-managing / workflow-compiling / TexeraWebApplication / 
ComputingUnitMaster) plus the Angular frontend against a host Postgres and 
Dockerized MinIO + LakeFS. `transformers==5.0.0rc3` installs cleanly with the 
rest of `amber/operator-requirements.txt`; sbt `stage` is green; amber Python 
tests are 461 passed + 2 pre-existing failures in `test_executor_manager` (same 
failures appear on `main`, unrelated to this PR).
   
   All those are covered by CI already. @aicam did you try to run some python 
ML operators?
   
   > One follow-up needed: transformers v5 removed the `TF*` classes. 
`common/workflow-operator/src/main/scala/org/apache/texera/amber/operator/huggingFace/HuggingFaceSentimentAnalysisOpDesc.scala`
 still imports `TFAutoModelForSequenceClassification` (line 64) in its 
generated Python — the symbol is unused in the operator body, but the import 
will throw `ImportError` at workflow runtime once this lands. Should be dropped 
in a follow-up.
   
   did we take care of this? or create an issue to track it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to