Ma77Ball opened a new pull request, #5057:
URL: https://github.com/apache/texera/pull/5057
### What changes were proposed in this PR?
Enrich the failure output of `bin/licensing/check_binary_deps.py` with two
pieces of context that previously required manual lookup for every offending
package: the dep's declared license string (read from `3rdpartylicenses.json`
for npm/agent-npm or `pip-licenses.csv` for python) and the per-module
`LICENSE-binary` file to edit. Each bullet now renders as `+ name@version
(license: X) → add to <file>` for new packages, `→ remove from <file>` for
stale, and `→ update in <file>` for drift, with the `ACTION REQUIRED` block
naming the same file. Transitive deps are covered the same way because the
input files already list everything bundled. No CI workflow changes; The
script's exit semantics and aggregation behavior are unchanged.
### Any related issues, documentation, or discussions?
Closes: #5056
### How was this PR tested?
Added five unit tests in `bin/licensing/test_check_binary_deps.py` covering
license rendering, target-file rendering, the jar no-license case, stale and
drift hints, and the no-target-file fallback. Full suite of 34 tests passes
locally via `python3 -m unittest discover -s bin/licensing -p "test_*.py"`.
Also smoke-tested by running the script against a synthetic
`3rdpartylicenses.json` and confirming the enriched bullets render correctly
for new, stale, and drifted entries.
### Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.7 in compliance with ASF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
