carloea2 commented on PR #5043: URL: https://github.com/apache/texera/pull/5043#issuecomment-4503857572
Thanks, agreed. I added concise JSDoc for the public contracts in the parser service, sync service, and component without expanding the implementation comments too much. Covered: - `UiUdfParameter`, `UiUdfParametersParseError`, `UiUdfParametersParserService`, and `parse(...)` - `UiUdfParametersSyncService`, both observables, `attachToYCode(...)`, `syncStructureFromCode(...)`, and the debounce constant - `UiUdfParametersComponent`, `getColumnField(...)`, and `configureDisabledState(...)` For the parse-error stream, I documented that an event without `message` clears the current error for that operator, and added `clearParseError(operatorId)` so the call site is explicit. Once this PR is merged, I can raise PR #2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
