Yicong-Huang commented on code in PR #5153:
URL: https://github.com/apache/texera/pull/5153#discussion_r3289997208
##########
frontend/build-version.js:
##########
@@ -17,17 +17,12 @@
* under the License.
*/
-const { gitDescribeSync } = require("git-describe");
+const { generate } = require("build-number-generator");
const { version } = require("./package.json");
const { resolve, relative } = require("path");
const { writeFileSync, existsSync, mkdirSync } = require("fs-extra");
-const gitInfo = gitDescribeSync({
- dirtyMark: false,
- dirtySemver: false,
-});
-
-gitInfo.version = version;
+const buildNumber = generate(version);
Review Comment:
can we simply call this method in source code, instead of doing so in post
install script? I think we can get rid of such a post install script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
