Yicong-Huang commented on code in PR #5153:
URL: https://github.com/apache/texera/pull/5153#discussion_r3293592690
##########
frontend/build-version.js:
##########
@@ -17,17 +17,12 @@
* under the License.
*/
-const { gitDescribeSync } = require("git-describe");
+const { generate } = require("build-number-generator");
const { version } = require("./package.json");
const { resolve, relative } = require("path");
const { writeFileSync, existsSync, mkdirSync } = require("fs-extra");
-const gitInfo = gitDescribeSync({
- dirtyMark: false,
- dirtySemver: false,
-});
-
-gitInfo.version = version;
+const buildNumber = generate(version);
Review Comment:
for dev environment, it is fine to either show a "dev" or git sha. This
feature (show build number) is mainly for production usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
