Yicong-Huang commented on PR #5643: URL: https://github.com/apache/texera/pull/5643#issuecomment-4715653722
Hi @eugenegujing i actually think it's fine to keep the PR as it is with minor fixes. The persisted audit history maybe an overkill: we can simply log it out. Also admin would be headache if needs to periodically confirm the deletion. It's hard to balance over defensive code and reckless code. Just be careful about destructive operations in general, moving forward as well. Also, a nit: let's make the pr description a bit concise. Also some of the comments can be a bit shorter to make communication more efficient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
