eugenegujing commented on PR #5643: URL: https://github.com/apache/texera/pull/5643#issuecomment-4783874447
@Yicong-Huang Thanks for the review! Addressed all the comments: storage.cleanup.enabled now defaults to false, runCleanupOnce is private[util], the per-round summary is now at debug level, and the session fetch is bounded with .orderBy(created_at).limit(500) so it can't OOM on a large table. The path-2 race is fixed by dropping the stale activePathsByDid snapshot in favor of a live hasActiveUploadSession check plus an mtime re-read right before each reset; the only remaining window is the irreducible sub-microsecond gap before the reset, since LakeFS can't join the DB transaction. On coverage, I expanded StagedFileCleanupJobSpec to 21 cases and added StorageConfigSpec and a LakeFSStorageClientSpec backed by real Postgres+MinIO+LakeFS testcontainers; the only lines left uncovered are the FileService start-up wiring and the scheduler/race-guard branch. Could you please review it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
