aicam opened a new pull request, #5757: URL: https://github.com/apache/texera/pull/5757
## What Reorganize the flat `bin/k8s/templates/` directory into a clear `common / aws / onprem` layout, and bring `values-development.yaml` back in sync with `values.yaml`. This is the first in a planned series of small, non-breaking PRs that make the Helm chart cleanly deployable on AWS/EKS while keeping on-prem/local as the unchanged default. This PR is **structure + alignment only** — no deployment behaves differently. ### 1. Template folder reorganization (no-op) Helm renders `templates/**` recursively, so moving files into subdirectories does not change rendered output. Every template moves under one of three folders by audience: - `templates/common/` — shared by every deployment (all services, deployments, routes, RBAC, namespace/init jobs). - `templates/onprem/` — on-prem/local only: `minio-persistence.yaml`. - `templates/aws/` — placeholder for AWS-only, value-gated templates added in later PRs (empty for now). A `templates/README.md` documents the convention, and `.helmignore` is added so `*.md`/`.gitkeep` are not loaded as manifests. **Proof of no-op:** `helm template texera bin/k8s` produces byte-identical output before and after this change (104 resources), and `helm lint bin/k8s` is clean. ### 2. `values-development.yaml` re-aligned with `values.yaml` The dev overlay had drifted from the source-of-truth `values.yaml`: - `imageRegistry`/`imageTag` updated from `ghcr.io/apache`/`latest` to `docker.io/apache`/`1.3.0-incubating-SNAPSHOT` to match `values.yaml`. - Added the `AUTH_JWT_SECRET` dev-default that already exists in `values.yaml` but was missing from the dev overlay. Without it, creating a Kubernetes computing unit fails with a `NoSuchElementException` (`None.get`) in `ComputingUnitManagingResource`, because the CU manager reads `AUTH_JWT_SECRET` from the environment unconditionally. ## Why The flat `templates/` directory mixes ~38 manifests with no signal about which are universal vs. environment-specific, which makes the upcoming AWS-enablement work hard to review. Establishing the `common/aws/onprem` structure first lets each later PR add a small, clearly-scoped, value-gated file under `aws/`. ## Testing Deployed the reorganized chart end-to-end on minikube with the on-prem/development profile (`apache` images): UI loads, dataset upload + preview work, and Kubernetes computing-unit creation succeeds and goes green (verifying the `AUTH_JWT_SECRET` fix). `helm lint` clean; `helm template` diff vs. before is empty for the reorg. ## Non-breaking On-prem/local remains the default and unchanged. No values were renamed or removed; `templates/aws/` is empty. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
