aicam commented on PR #5757: URL: https://github.com/apache/texera/pull/5757#issuecomment-4781238274
Thanks for the review @bobbai00 @Ma77Ball — addressed in ca0a4c7: - **Folder names** (@bobbai00): renamed `templates/common` → `templates/base` and `templates/onprem` → `templates/on-prem`, and updated `templates/README.md` to match. - **`imageRegistry`/`imageTag`** (@Ma77Ball, @bobbai00): reverted `values-development.yaml` back to `ghcr.io/apache` / `latest` so the out-of-the-box `helm install -f values-development.yaml` keeps pulling published images. - **Hardcoded `AUTH_JWT_SECRET`** (@Ma77Ball): dropped from this PR as well. This keeps PR1 a pure mechanical reorg with **zero value/logic changes**. I'll open a separate follow-up for an install-time generated dev secret (`lookup` + `randAlphaNum`) as you suggested. Verification: `helm template texera bin/k8s` renders byte-identical output to the pre-rename commit (5085 lines, only `# Source:` paths differ), and `helm lint` is clean. The reorg remains behavior-neutral. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
