Copilot commented on code in PR #5783:
URL: https://github.com/apache/texera/pull/5783#discussion_r3439428387
##########
amber/src/main/python/core/architecture/managers/console_message_manager.py:
##########
@@ -30,3 +37,32 @@ def get_messages(self, force_flush: bool = False) ->
Iterator[ConsoleMessage]:
def put_message(self, msg: ConsoleMessage) -> None:
self.print_buf.put(msg)
+
+ def report_exception(self, worker_id: str, exc_info: ExceptionInfo) ->
None:
+ """Queue an ERROR console message describing ``exc_info``.
+
+ Builds the operator-facing error message for an uncaught exception,
+ whether it surfaced from a UDF on the data path (DataProcessor) or
+ from a user expression evaluated on the main loop thread. Centralizing
+ it keeps both paths reporting identically; callers are responsible for
+ recording the exception with the exception manager and flushing/pausing
+ as appropriate.
+ """
+ tb = traceback.extract_tb(exc_info[2])
+ filename, line_number, func_name, text = tb[-1]
Review Comment:
`text` is assigned via traceback tuple-unpacking but never used.
Ruff/pyflakes will flag this as an unused local variable (F841), which can fail
the Amber CI lint step. Use a dummy variable name (e.g., `_`) instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
