aglinxinyuan commented on code in PR #5783:
URL: https://github.com/apache/texera/pull/5783#discussion_r3449179929
##########
amber/src/main/python/core/architecture/managers/console_message_manager.py:
##########
@@ -30,3 +37,32 @@ def get_messages(self, force_flush: bool = False) ->
Iterator[ConsoleMessage]:
def put_message(self, msg: ConsoleMessage) -> None:
self.print_buf.put(msg)
+
+ def report_exception(self, worker_id: str, exc_info: ExceptionInfo) ->
None:
Review Comment:
Done — moved the construction out into
`core/util/console_message/error_message.py::create_error_console_message`,
which just returns a `ConsoleMessage`. `DataProcessor` now builds via the
factory and queues it with the manager's existing `put_message`, so
`ConsoleMessageManager` is back to message-management only. Added
`test_error_message.py` for the factory. (`4bdc966`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
