aglinxinyuan opened a new pull request, #5953: URL: https://github.com/apache/texera/pull/5953
### What changes were proposed in this PR? Pin behavior of the two previously-untested relational join descriptors in `common/workflow-operator`. No production-code changes. | Spec | Source class | Tests | | --- | --- | --- | | `CartesianProductOpDescSpec` | `CartesianProductOpDesc` | 5 | | `HashJoinOpDescSpec` | `HashJoinOpDesc` | 5 | **Behavior pinned** | Surface | Contract | | --- | --- | | `operatorInfo` | exact name/description; Join group; left/right 2-in, 1-out shape | | field defaults | HashJoin `buildAttributeName`/`probeAttributeName` null, `joinType` `INNER` | | schema propagation | CartesianProduct concatenates left + right, renaming right-side duplicates (`k` → `k#@1`); HashJoin drops the probe key, keeps the build key, and renames retained right-side clashes | | `getPhysicalOp` | CartesianProduct wires `OpExecWithClassName(...CartesianProductOpExec)` with the correct ports | | Round-trip | config fields preserved through the polymorphic `LogicalOp` base, with the correct `operatorType` discriminator | ### Any related issues, documentation, discussions? Part of the ongoing `workflow-operator` unit-test coverage effort. ### How was this PR tested? - `sbt "WorkflowOperator/testOnly *CartesianProductOpDescSpec *HashJoinOpDescSpec"` — 10 tests, all green - `sbt "WorkflowOperator/Test/scalafmtCheck"` and `sbt "WorkflowOperator/scalafixAll --check"` — clean - CI to confirm ### Was this PR authored or co-authored using generative AI tooling? Generated-by: Claude Code (Opus 4.8 [1M context]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
