bobbai00 commented on code in PR #5932:
URL: https://github.com/apache/texera/pull/5932#discussion_r3484420377


##########
bin/k8s/values.yaml:
##########
@@ -65,6 +65,18 @@ postgresql:
     initdb:
       scriptsConfigMap: "postgresql-init-script"
 
+# Object storage (S3) used by the Texera services. Leave storage.s3.endpoint
+# empty to use the in-cluster MinIO (the `minio:` block below). Set it to an
+# S3-compatible endpoint URL -- together with region and credentials -- to
+# point the services at an external store (e.g. AWS S3) instead.
+storage:
+  s3:

Review Comment:
   we have currently two places that use s3:
   - datasetS3: LakeFS uses S3 as its underlying storage
   - executionS3: Workflow execution results are using s3
   
   Which one is this PR introducing ?
   
   Seems both are touched in this PR. But should LakeFS's s3 connection also be 
updated because it should use `datasetS3` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to