Ma77Ball commented on code in PR #5932:
URL: https://github.com/apache/texera/pull/5932#discussion_r3508161486
##########
bin/k8s/values.yaml:
##########
@@ -65,6 +65,18 @@ postgresql:
initdb:
scriptsConfigMap: "postgresql-init-script"
+# Object storage (S3) used by the Texera services. Leave storage.s3.endpoint
+# empty to use the in-cluster MinIO (the `minio:` block below). Set it to an
+# S3-compatible endpoint URL -- together with region and credentials -- to
+# point the services at an external store (e.g. AWS S3) instead.
Review Comment:
This block only reroutes the **application tier** (`file-service` and
`workflow-computing-unit-manager`). The LakeFS blockstore
(`lakefs.lakefsConfig`) and the Lakekeeper warehouse defined a few lines below
still hardcode the in-cluster MinIO endpoint and credentials, which your PR
description correctly calls out as deferred. As written, "Object storage (S3)
used by the Texera services" reads as if setting `storage.s3` moves all of
Texera's object storage, so a deployer could point the app tier at external S3
while datasets written through LakeFS silently keep landing in MinIO. Suggest
scoping the comment and naming the gap:
```suggestion
# Object storage (S3) for the application tier (file-service and
# workflow-computing-unit-manager). Leave storage.s3.endpoint empty to use
the
# in-cluster MinIO (the `minio:` block below). Set it to an S3-compatible
# endpoint URL, together with region and credentials, to point those services
# at an external store (e.g. AWS S3). Note: this does NOT reroute the LakeFS
# blockstore or the Lakekeeper warehouse below, which still use in-cluster
# MinIO; external-S3 wiring for those is a planned follow-up.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
