mengw15 commented on code in PR #6045: URL: https://github.com/apache/texera/pull/6045#discussion_r3504228769
########## amber/src/test/integration/org/apache/texera/amber/core/storage/model/VirtualDocumentSpec.scala: ########## Review Comment: Yes, `VirtualDocument` lives in `common/workflow-core` (`core.storage.model`). `VirtualDocumentSpec` is its shared test base and is used only by the two iceberg document specs in this move — they `extend VirtualDocumentSpec[Tuple]`, and amber's test scope sees workflow-core's **main** but not its **test** sources, so it had to move with them or they wouldn't compile here. If you'd rather keep it next to `VirtualDocument` in `common`, the alternative is to leave it there and add `amber.dependsOn(WorkflowCore % "test->test")` (the pattern amber already uses for `DAO`/`Auth`). Which do you prefer? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
