mengw15 commented on code in PR #6045:
URL: https://github.com/apache/texera/pull/6045#discussion_r3504933741


##########
amber/src/test/integration/org/apache/texera/amber/core/storage/model/VirtualDocumentSpec.scala:
##########


Review Comment:
   Update: `WorkflowCore % "test->test"` runs into a classpath conflict — 
WorkflowCore's test scope pulls Hadoop → `com.sun.jersey` 1.19, whose bundled 
JAX-RS 1.x `Response` (no `getHeaderString`) shadows amber's 
`javax.ws.rs-api:2.1.1` and breaks the existing `HuggingFaceModelResourceSpec`. 
(Fine for the light `DAO`/`Auth` test scopes, not the heavy WorkflowCore one.)
   
   So for now `VirtualDocumentSpec` stays in amber — moved to 
`amber/src/test/scala` as a generic `AnyFlatSpec` harness (not an integration 
test); `Test/compile` and `amber-integration` are green. Longer term, 
generalizing `amber-integration` into a shared `integration` job (as you 
suggested) would let it move back to `common`. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to