mengw15 opened a new pull request, #6049:
URL: https://github.com/apache/texera/pull/6049

   ### What changes were proposed in this PR?
   
   Production uses the REST (Lakekeeper) Iceberg catalog, but 
`common/config/src/main/resources/storage.conf` still defaulted 
`iceberg.catalog.type` to `postgres`. This PR flips the default to `rest` so CI 
stays close to production. The `STORAGE_ICEBERG_CATALOG_TYPE` env override on 
the next line is untouched, and local-dev / single-node already set `rest` via 
env, so they are unaffected; `postgres` stays a supported type.
   
   Depends on **#6045** (Task 1, merged), which moved the live-catalog iceberg 
specs into the integration suite so the amber unit job no longer resolves the 
default catalog. **Task 3** (make the CI integration suite mirror prod on REST 
while keeping postgres-catalog coverage) follows.
   
   ### Any related issues, documentation, discussions?
   
   Part of #6034 (Task 2 of 3). Follows #6045.
   
   ### How was this PR tested?
   
   One-line config default change, no code change:
   - After #6045, the only specs that resolve the catalog via 
`IcebergCatalogInstance.getInstance()` are `@IntegrationTest` and run in the 
`amber-integration` job (which provisions Lakekeeper), not the unit job — 
confirmed by grep across all test sources.
   - No test asserts the default value: `PythonWorkflowWorkerStartupConfigSpec` 
checks startup-config key *names* (type-independent), not 
`icebergCatalogType`'s value.
   - CI's `build / amber` (unit) and `build / amber-integration` exercise the 
runtime behavior.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (claude-opus-4-8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to