Yicong-Huang commented on code in PR #6049:
URL: https://github.com/apache/texera/pull/6049#discussion_r3509308068
##########
common/config/src/main/resources/storage.conf:
##########
@@ -21,7 +21,7 @@ storage {
# Configuration for Apache Iceberg, used for storing the workflow results
& stats
iceberg {
catalog {
- type = postgres # either hadoop, rest, or postgres
+ type = rest # either hadoop, rest, or postgres
Review Comment:
Do we support Hadoop?
##########
.github/workflows/build.yml:
##########
@@ -281,6 +281,8 @@ jobs:
# those run in the amber-integration job below.
env:
AMBER_TEST_FILTER: skip-integration
+ # unit job uses its provisioned postgres catalog; default (rest)
needs a Lakekeeper not run here
+ STORAGE_ICEBERG_CATALOG_TYPE: postgres
Review Comment:
I thought we moved all tests needs catalog to amber-integration? Why do we
still have to keep Postgres in CI?
Can we allow run unit tests without a catalog?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
