aicam commented on code in PR #6240:
URL: https://github.com/apache/texera/pull/6240#discussion_r3574129957
##########
frontend/src/app/workspace/service/validation/validation-workflow.service.ts:
##########
@@ -388,6 +388,13 @@ export class ValidationWorkflowService {
link => validOperatorIds.has(link.source.operatorID) &&
validOperatorIds.has(link.target.operatorID)
);
- return new WorkflowGraph(validOperators, validLinks,
texeraGraph.getAllCommentBoxes());
+ // This graph is a throwaway used only to build a logical plan for
compilation/validation; it is read once and
+ // never destroyed. Pass enableSharedEditing=false so it does not open
(and leak) a /rtc WebSocket per edit.
+ return new WorkflowGraph(
+ validOperators,
+ validLinks,
+ texeraGraph.getAllCommentBoxes(),
+ /* enableSharedEditing */ false
Review Comment:
Agreed — resolved in 3ae20d718. The `enableSharedEditing` flag is gone
entirely: `SharedModel` now opens a `/rtc` connection only when a workflow ID
is provided (the same contract `loadNewYModel(workflowId, ...)` already
documented — "workflowId… needed if you want to join shared editing"). This
call site is back to the plain 3-arg `new WorkflowGraph(...)`; since the
throwaway graph has no `wid`, it is local-only by construction, and
`WorkflowGraph` no longer knows anything about shared editing. The old no-`wid`
fallback (connect to a random UUID room) provided no real collaboration anyway
— each client got its own random room — so removing it changes no user-visible
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
