aicam commented on PR #6240:
URL: https://github.com/apache/texera/pull/6240#issuecomment-4962665909
@aglinxinyuan Good point — I verified the *before-fix* behavior as well and
added it to the description ("How was this PR tested?"). Summary of the
before-fix evidence:
**Client-side (DevTools → Network → WS, pre-fix build):** opening a workflow
starts one `/rtc` socket, and then every single edit (operator add/delete,
property change, link add/remove) spawns an **additional** `/rtc` socket to a
random-UUID room. These extra sockets never close and auto-reconnect forever,
so the WS count climbs monotonically with every edit — a few minutes of editing
accumulates dozens of permanent connections from one tab.
**Server-side (production y-websocket server):** counting ESTABLISHED
connections on the shared-editing server showed the same signature — hundreds
of connections from only a handful of active users, steadily climbing while
they edited, with the room names dominated by random UUIDs (the throwaway
validation graphs) rather than numeric workflow IDs. That growth is what
exhausted Envoy's default per-cluster limit of 1024 connections and broke
shared editing in production (#6239). Tabs still running the pre-fix bundle
keep leaking in this pattern today, while tabs on the fixed bundle hold exactly
one connection per open workflow.
Also trimmed the changed-files list from the PR description as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
