mengw15 opened a new pull request, #6829:
URL: https://github.com/apache/texera/pull/6829
### What changes were proposed in this PR?
Extends the existing `WorkflowEditorComponent` spec with the file's
non-rendering
slice — connection validation, the clipboard handlers, and the delete /
select-all paths the keyboard tests never reach. The paper-event and pointer
handlers stay out of scope (they need real `dia.Paper` geometry / browser
mode).
12 new tests take the component from 68.6% to 74.0% statement coverage (+31
lines) and bring every targeted method to 100%:
- `validateJointOperatorConnection` — rejects a link drawn out of an input
port
and one dropped onto an output port; delegates an output→input pair to the
operator-level check (proved by re-running once the link exists).
- `validateOperatorConnection` guards — self-connection, a missing port on
either end, and an endpoint that is not an operator.
- `deleteElements` — highlighted links and comment boxes are deleted, not
just
operators.
- `handleElementSelectAll` — ⌘/Ctrl+A also highlights links and comment
boxes.
- `handleElementCopy` / `handleElementCut` / `handleElementPaste` — copy
caches
the selection, cut caches then deletes it, paste delegates to the operator
menu.
- `handleDisableOperator` — repaints the operator on disable and on
re-enable.
No production code was changed.
### Any related issues, documentation, discussions?
Closes #6827.
### How was this PR tested?
`ng test --watch=false --include
src/app/workspace/component/workflow-editor/workflow-editor.component.spec.ts`
— 57 passed (45 existing + 12 new), run 3× for determinism. The failure path
was
verified by breaking an assertion (red, non-zero exit), and eslint/prettier
are
clean. Coverage was measured with `--coverage` before and after to confirm
each
targeted method reached 100%.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
