Mrudhulraj commented on code in PR #6402:
URL: https://github.com/apache/texera/pull/6402#discussion_r3639230464
##########
frontend/src/app/common/service/user/auth.service.ts:
##########
@@ -62,13 +62,15 @@ export class AuthService {
* This method will handle the request for user registration.
* It will automatically login, save the user account inside and trigger
userChangeEvent when success
* @param username
+ * @param email
* @param password
*/
- public register(username: string, password: string): Observable<Readonly<{
accessToken: string }>> {
+ public register(username: string, email: string, password: string):
Observable<Readonly<{ accessToken: string }>> {
return this.http.post<Readonly<{ accessToken: string }>>(
`${AppSettings.getApiEndpoint()}/${AuthService.REGISTER_ENDPOINT}`,
{
username,
+ email,
password,
}
Review Comment:
I have updated the specs and run the testcases, all testcases now accept an
email.
##########
frontend/src/app/common/service/user/user.service.ts:
##########
@@ -81,9 +81,9 @@ export class UserService {
this.changeUser(undefined);
}
- public register(username: string, password: string): Observable<void> {
+ public register(username: string, email: string, password: string):
Observable<void> {
return this.authService
- .register(username, password)
+ .register(username, email, password)
.pipe(switchMap(({ accessToken }) =>
this.handleAccessToken(accessToken)));
}
Review Comment:
I have updated the specs and run the testcases, all testcases now accept an
email.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
