aglinxinyuan commented on PR #6186: URL: https://github.com/apache/texera/pull/6186#issuecomment-5085304422
Tested the `cached-property` 1.5.2 → 2.0.1 bump locally before merging. **1. Install + metadata** — `pip install cached-property==2.0.1` in a clean venv resolves to name `cached-property`, version `2.0.1`, license **BSD** (matches the BSD 3-Clause section in `amber/LICENSE-binary-python`). **2. API compatibility** — amber only uses `from cached_property import cached_property` + the `@cached_property` decorator (`executor_manager.py:50`). Smoke test confirms the import works and the decorator still caches (value computed once, returned on repeat access). 2.0.1 only drops Py2 support and adds Py3.8+ — the decorator API is unchanged. **3. License-binary check** — ran the exact CI script (`bin/licensing/check_binary_deps.py python … --ignore-transitive-version`) against a reality set built from the actually-installed 2.0.1: | State | Manifest claims | Installed | Result | Exit | |---|---|---|---|---| | Before | `1.5.2` | `2.0.1` | `DRIFT (direct)` | 1 ❌ | | After | `2.0.1` | `2.0.1` | `OK: match` | 0 ✅ | The "before" row is exactly the failure CI was hitting; the sync in `amber/LICENSE-binary-python` clears it. CI on the fixed branch is fully green — all four `build / pyamber` legs (3.10–3.13) pass, including the 3.12/3.13 legs that run the license check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
