aglinxinyuan commented on code in PR #6709:
URL: https://github.com/apache/texera/pull/6709#discussion_r3673858527
##########
project/plugins.sbt:
##########
@@ -40,5 +40,5 @@ libraryDependencies ++= Seq(
// PostgresDatabase.loadForeignKeys can't read (it looks up lowercase
key_seq),
// breaking JOOQ code generation. Fixed only in jOOQ 3.20+
(jOOQ/jOOQ#17873); jOOQ
// is capped at 3.19.36 here (the last Java-17 release), so keep this driver
pinned.
- "org.postgresql" % "postgresql" % "42.7.4"
+ "org.postgresql" % "postgresql" % "42.7.13"
Review Comment:
Checked this one — it's the comment that's stale here, not the bump.
`jooq-codegen` 3.19.36 already carries the jOOQ/jOOQ#17873 fix:
`PostgresDatabase.loadForeignKeys` probes `result.field("key_seq")` and, when
the driver hands back the JDBC-spec uppercase labels, upper-cases every
subsequent label lookup, so both casings work. 3.16.23 — the version we first
hit this on — is the one that hard-codes the lowercase labels.
CI on this PR confirms it end to end: `postgresql-42.7.13` is on the codegen
classpath and the amber build logs `JOOQ code generation completed
successfully`, with the DDL's 44 `FOREIGN KEY` constraints exercising exactly
that path. The generated sources aren't committed, so a codegen failure would
fail the compile outright rather than pass quietly.
Pushed f1b7caa to refresh the rationale so it describes the real condition
instead of asserting a pin we no longer need. Runtime pgjdbc in
`amber/build.sbt` is already 42.7.13, so this was the last 42.7.4 holdout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
