aglinxinyuan opened a new pull request, #7463:
URL: https://github.com/apache/texera/pull/7463

   ### What changes were proposed in this PR?
   
   Removes the deprecated **project** feature from the Angular frontend. The 
feature was hidden behind `projects_enabled = false` in #3343 (2025-04-02) and 
has been unmaintained since; #5172 reached consensus to delete it rather than 
keep carrying it.
   
   This is the frontend half. The backend endpoints and the database schema go 
separately, so this PR is safe to land on its own — the `/project` endpoints 
simply stop being called.
   
   **27 files deleted, 55 edited (+79 / −4798).**
   
   | Area | What went |
   | --- | --- |
   | Components | the whole `user-project/` tree — list page, section page, 
list item, public-project modal, add/remove-workflow modals (22 files) |
   | Services | `UserProjectService`, `StubUserProjectService`, 
`PublicProjectService` |
   | Types | `DashboardProject` / `PublicProject`, `SearchResult.project`, 
`isDashboardProject`, `DashboardWorkflow.projectIDs` |
   | Routing | `user/project`, `user/project/:pid`, the `USER_PROJECT` 
constant, 6 `app.module.ts` declarations |
   | Config | `SidebarTabs.projects_enabled`, the sidebar tab, the 
admin-settings toggle |
   | Search / filters | project filter chips, `projectIds` search params, the 
project arm of the entry builder, `EntityType.Project` |
   
   **UI impact.** Every surface below `projects_enabled` was already hidden by 
default, so a default deployment renders identically before and after — no 
user-visible change to screenshot. The one exception is the **admin settings 
page**, which loses its now-meaningless *Projects* toggle row (twelve switches 
→ eleven).
   
   ```
   Before:  Admin Settings ▸ tabs ▸ [Your Work][Projects][Workflows][Datasets]…
   After:   Admin Settings ▸ tabs ▸ [Your Work][Workflows][Datasets]…
   ```
   
   Two adjacent cleanups were deliberately **left out** of scope, since they 
are unrelated dead code rather than part of this feature: 
`hub-search-result.component.ts`'s `@Input() accessLevel` and 
`search-results.component.ts`'s `@Input() pid`.
   
   ### Any related issues, documentation, discussions?
   
   Closes #7460
   
   Removal agreed in #5172; the backend and schema half is #7461. Also updates 
`frontend/README.md`, the only doc line that named the feature.
   
   ### How was this PR tested?
   
   Existing tests, adjusted where a project fixture was doing double duty as a 
generic sample (e.g. the "non-shareable entry" case now uses `"file"` instead 
of `"project"`), and deleted where a test existed solely to exercise project 
behaviour.
   
   ```bash
   cd frontend && npx tsc --noEmit && npx ng test --watch=false && yarn 
format:ci
   ```
   
   | Check | Result |
   | --- | --- |
   | `tsc --noEmit` | clean |
   | `ng test --watch=false` | 195 files, **4118 passed**, 1 skipped, 0 failed |
   | `eslint ./src` | clean |
   | `prettier-eslint --list-different` | clean |
   
   `ng build` was also run: it reports 13 errors, all inside `node_modules` 
(monaco `.ttf`/`.svg`/`.css` loaders) and none under `src/app`. Confirmed 
pre-existing rather than caused by this change by building a pristine 
`origin/main` worktree against the same `node_modules` — identical 13 errors.
   
   ### Was this PR authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to