parshimers commented on code in PR #7172:
URL: https://github.com/apache/texera/pull/7172#discussion_r3752799886
##########
.github/workflows/benchmarks.yml:
##########
@@ -466,3 +475,22 @@ jobs:
alert-threshold: "150%"
comment-on-alert: false
summary-always: true
+
+ - name: Clean up job artifacts
+ # arc-bench-linux is a dedicated machine every bench run lands on, so
+ # its leftovers (sbt target/, bench-results/, the main-baseline
+ # checkout) accumulate faster than anywhere else — and stale state on
+ # the bench box is a comparability risk, not just a disk one. Runs
+ # after the artifact upload above, so no results are lost. always() so
+ # a failed or cancelled run cleans up too; the GitHub-hosted fallback
+ # is a throwaway VM and skips it. `git clean -x` covers gitignored
+ # build output, `-ff` nested git dirs; .git stays so the next
+ # checkout is incremental. The fallback covers a run whose checkout
+ # never completed.
+ if: ${{ always() && runner.environment == 'self-hosted' }}
+ working-directory: ${{ github.workspace }}
+ run: |
Review Comment:
kind of seems like the code around line 227 and this do the same thing, just
in a different way? the one in 227 might be better, because it asserts the
GITHUB_WORKSPACE isn't null somehow and bails out if it is. i don't know what
would happen in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
