parshimers commented on code in PR #7172:
URL: https://github.com/apache/texera/pull/7172#discussion_r3752811771
##########
.github/workflows/build.yml:
##########
@@ -734,6 +771,21 @@ jobs:
flags: amber-integration
report_type: test_results
fail_ci_if_error: false
+ - name: Clean up job artifacts
+ # This job starts its infra with `docker run -d` rather than
+ # `services:`, so nothing removes those containers for it — and on a
+ # classic runner they keep running, holding ports 5432 / 9000 / 8181
+ # against the next job (whose own `docker run` would then fail on the
+ # name and the port). -v also drops the anonymous volumes postgres
+ # declares. See the frontend job above for the full rationale.
+ if: ${{ always() && runner.environment == 'self-hosted' }}
+ working-directory: ${{ github.workspace }}
+ run: |
Review Comment:
is it possible to just not declare volumes for these so they don't have to
get cleaned up each time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
