kunwp1 commented on code in PR #7473:
URL: https://github.com/apache/texera/pull/7473#discussion_r3754421000
##########
common/config/src/main/scala/org/apache/texera/common/config/StorageConfig.scala:
##########
@@ -93,7 +95,9 @@ object StorageConfig {
// Per-user warehouses (#6870). On only when the switch is on AND the
catalog is REST
// (Lakekeeper): warehouses are Lakekeeper entities, so any other catalog
type keeps
// the feature off regardless of the switch.
- val warehouseEnabled: Boolean =
+ // warehouseEnabled is a var because tests need to exercise the enabled path
+ // (mirroring s3Endpoint above); production code never writes it.
+ var warehouseEnabled: Boolean =
Review Comment:
It's better to use `val` if the variable is immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
