kunwp1 commented on code in PR #7473:
URL: https://github.com/apache/texera/pull/7473#discussion_r3754648668
##########
amber/src/main/scala/org/apache/texera/web/resource/SyncExecutionResource.scala:
##########
@@ -535,6 +537,8 @@ class SyncExecutionResource extends LazyLogging {
storageUriOption match {
case Some(storageUri) =>
+ // Refuse to read a per-user-warehouse result while the feature is
off (#6930).
+ WarehouseReadGuard.assertReadable(storageUri)
Review Comment:
I think the changes you made are too aggressive because you moved this code
out of try block as well. Can you revert it and try a different way to handle
the exception of assertReadable?
```
val storageUriOption =
WorkflowExecutionsResource.getResultUriByLogicalPortId(
executionId,
OperatorIdentity(opId),
PortIdentity()
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
