mengw15 commented on PR #7539: URL: https://github.com/apache/texera/pull/7539#issuecomment-5260719052
Both suppressed comments addressed: - **Writer regression test** — right that nothing guarded it: reverting `flushBuffer` to an eagerly-held `Table` left all existing writer specs green. Added in 8ab409c84 — the writer is constructed with catalog A cached, the warehouse entry is swapped for catalog B before the flush, and the test asserts the metadata load goes through B (verified red against the pinned implementation). - **Stale description** — updated: the body described the replacement-closes-displaced semantics that CI disproved, and claimed size eviction was untested. It now states the actual contract (only evicted entries are closed; a displaced catalog stays open for its owner) and the coverage (size/idle eviction on isolated caches with a manual ticker, per-use resolution pinned at each of the four holders). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
