kunwp1 commented on code in PR #7539:
URL: https://github.com/apache/texera/pull/7539#discussion_r3778123967
##########
amber/src/main/python/core/storage/iceberg/iceberg_catalog_instance.py:
##########
@@ -35,6 +35,11 @@ class IcebergCatalogInstance:
testing or reconfiguration.
"""
+ # Deliberately unbounded, unlike the Scala side's bounded cache (#7290): a
Python
+ # worker process is spawned per worker and destroyed when the execution
ends
+ # (PythonWorkflowWorker.postStop), so this dict holds the single warehouse
that
+ # execution used and dies with the process. If PVMs ever become long-lived
(e.g.
+ # pooled across executions), this needs the same bounding the JVM
singleton has.
Review Comment:
I understand that you wanted to say python side fix is not needed but I
don't think we need to add this comment in the codebase. The PR description is
good enough to explain this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
