aglinxinyuan opened a new pull request, #7621:
URL: https://github.com/apache/texera/pull/7621
### What changes were proposed in this PR?
Deletes `WorkflowSnapshotService`, which calls REST endpoints that no longer
exist, and the model type used only by it. Pure deletion, no behaviour change:
**−100 lines**.
The service targets `${AppSettings.getApiEndpoint()}/snapshot` — `PUT
/snapshot/upload` and `GET /snapshot/{sid}`. There is no `@Path("/snapshot")`
resource anywhere in the Scala sources, so both requests would 404 if anything
invoked them.
Nothing does. The service's only references are in
`execute-workflow.service.spec.ts`, which imports it and calls `TestBed.inject`
but never asserts on it — an inert injection, removed here along with the
import and its field. `WorkflowSnapshotEntry` is used by the service and
nowhere else.
> Reviewer note: `html2canvas` stays — `report-generation.service.ts` uses
it independently of this service.
### Any related issues, documentation, discussions?
Closes #7618
### How was this PR tested?
Existing tests only — this PR adds none; it removes a service nothing
exercised.
Locally, from `frontend/`:
- `npx ng test --watch=false
--include='**/execute-workflow.service.spec.ts'` — 35 tests, all pass after
dropping the inert injection.
- `yarn --cwd frontend format:ci` — clean.
Verification, re-runnable by a reviewer:
```
git grep -n WorkflowSnapshotService # only the deleted service
after this change
git grep -n '@Path("/snapshot' -- '*.scala' # no backend route exists
```
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
