aglinxinyuan commented on code in PR #7623:
URL: https://github.com/apache/texera/pull/7623#discussion_r3793443347
##########
.github/workflows/build.yml:
##########
@@ -86,7 +86,20 @@ jobs:
frontend:
if: ${{ inputs.run_frontend }}
runs-on: ${{ matrix.os }}
+ # Only the "Install dependency" step below is bounded, so a spec that
+ # truly hangs would otherwise run to GitHub's implicit 6h cap — billed at
+ # 10x on the macOS leg. Recent green runs take 4-12 minutes and install
+ # alone may take 20, so 30 bounds a hang while still absorbing a cold
+ # yarn cache on a slow runner.
Review Comment:
Right on both counts, and I checked the numbers against the API rather than
take them from the reply — run `31869822969`, per step:
| Leg | Job | Install | Rest |
| --- | --- | --- | --- |
| ubuntu-latest | 8.6 min | 37s | 8.0 min |
| macos-latest | 10.0 min | 49s | 9.2 min |
| windows-latest | 10.7 min | 74s | 9.5 min |
So the 20 was indeed the step's budget at `:142`, not an observation, and
the absorption claim inverts: install at its full 20 would put windows at 29.5
against a 30 cap.
Reworded in 2e68703 to size off the legs — 8.6-10.7 minutes end to end,
install under 90s everywhere, so 30 is ~3x the slowest with ~19 minutes of
slack. Kept the value at 30 as you suggested. I went with the measured range
plus the install figure rather than the suggested wording, since naming
install's real cost is what stops the next reader making the same 20-minute
misread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
