aglinxinyuan commented on code in PR #7623:
URL: https://github.com/apache/texera/pull/7623#discussion_r3841599991
##########
.github/workflows/build.yml:
##########
@@ -86,7 +86,25 @@ jobs:
frontend:
if: ${{ inputs.run_frontend }}
runs-on: ${{ matrix.os }}
+ # Only the "Install dependency" step below is bounded, so a spec that
+ # truly hangs would otherwise run to GitHub's implicit 6h cap, holding one
+ # of the 50 concurrent macOS jobs the whole `apache` org shares for that
+ # window. Sized off observed *green* legs rather than a typical one,
Review Comment:
Both fair — fixed in 7b872d95. I took the wording and reflowed the paragraph
rather than paste the line verbatim: the suggested line runs to 88 columns and
this block wraps at 78, so the substance is yours, the wrapping is the block's.
```
- # window. Sized off observed *green* legs rather than a typical one,
+ # window. The timeout is based on observed *green* legs rather than a
+ # typical one, ...
```
Widest line in the block is now 78. Same idiom appeared twice in the
description (the section heading and the sentence about the earlier `30`), so
both say `based on` now too.
Worth adding to the sizing evidence while it's here: the three legs on the
previous head all went green at ubuntu 8m48s / windows 11m13s / macOS 15m14s —
the macOS one lands mid-range against the 10.0-21.1 min band the comment is
built on, so 45 still reads as ~2x the worst green leg rather than a number
chosen once and left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
